PHP Problem

[X11]

There is something wrong with this code, only I have no idea what.

Code: Select all

        $request = db_query("
                SELECT ID_MSG, ID_MEMBER
                FROM {$db_prefix}messages
                WHERE ID_TOPIC = $topic " . (isset($_REQUEST['only_attach']) && $_REQUEST['only_attach'])? 'AND ID_MSG IN (' . implode(',', $ID_MSG) . ')' : '') . "
                ORDER BY ID_MSG " . ($ascending ? '' : 'DESC') . ($modSettings['defaultMaxMessages'] == -1 ? '' : "
                LIMIT $start, $limit"), __FILE__, __LINE__);


It does this...

Code: Select all

Parse error: parse error, unexpected ',' in /users/kintaro/public_html/labs/Sources/Display.php on line 560


[X11]

Okay, I changed that, which brings about another problem.

Code: Select all

2: implode(): Bad arguments.
File: /users/kintaro/public_html/labs/Sources/Display.php
Line: 558


Basically it doesn't like this line...

Code: Select all

                WHERE ID_TOPIC = $topic " . (isset($_REQUEST['only_attach']) && $_REQUEST['only_attach'])? 'AND ID_MSG IN (' . implode(',', $ID_MSG) . ')' : '' . "


[Void Main]

When you say "Okay, I changed that", what exactly did you change? I bet the problem is actually before the line you quote. I also see spacing problems in your SQL in the first post. It would be a lot easier to see the entire program.

[X11]

I got rid of the last ) in that WHERE ID_TOPIC line.

[Void Main]

Are you saying you changed it from this:

Code: Select all

                WHERE ID_TOPIC = $topic " . (isset($_REQUEST['only_attach']) &&


to this?

Code: Select all

                WHERE ID_TOPIC = $topic " . (isset($_REQUEST['only_attach'] &&


which most certainly isn't right. What is this a part of?

[X11]

I changed it to this

Code: Select all

   WHERE ID_TOPIC = $topic " . (isset($_REQUEST['only_attach']) && $_REQUEST['only_attach'])? 'AND ID_MSG IN (' . implode(',', $ID_MSG) . ')' : '' . "


[Void Main]

Is this part of a program that was already working that you are modifying? If so, can I see the original?

[X11]

It happened after automatically installing modifications in a forum, Simple Machines Forum.

I have got some support on the forum for that forum. And I am now left to this SQL error...

Code: Select all

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND ID_MSG=' at line 1
File: /users/kintaro/public_html/labs/Sources/Display.php
Line: 560


For this query...

Code: Select all

        $request = db_query("
                SELECT ID_MSG, ID_MEMBER
                FROM {$db_prefix}messages
                WHERE ID_TOPIC = $topic " . (isset($_REQUEST['only_attach']) && $_REQUEST['only_attach'])? 'AND ID_MSG=' . $ID_MSG : '' . "
                ORDER BY ID_MSG " . ($ascending ? '' : 'DESC') . ($modSettings['defaultMaxMessages'] == -1 ? '' : "
                LIMIT $start, $limit"), __FILE__, __LINE__);


[Void Main]

Can't you back out the mods and then ask the person who wrote the mod what's broke?

[X11]

I could but I have no idea which bloody one did it (I installed lots, and I probably should have been making backups).

[Void Main]

I probably should have been making backups

Hmmm, haven't we been here before? :)

[X11]

:'( I know.

[X11]

Okay, I found the mods and fscked them off away from my fscking forum which took me forever but oh well

IT WORKS!!!1111one

Good reason to make a backup.